On 2012.05.24 14:12, Xiaofan Chen wrote: > I am not so sure if gerrit is good for libusbx or not. From the OpenOCD > side it seems to be a success mostly. But it does prevent some users > from posting patches as well. OpenOCD is considered to be a big > project whereas libusb/libusbx are much smaller.
Yeah. To tell the truth, I don't care much about gerrit per se (especially as it limits how one can use git, by dropping git hooks for instance), and I agree that it adds an entry-level hurdle that is likely to discourage some people. What I do care about however, and the whole point of having gerrit as far as I'm concerned, is the build automation and validity checks we can get through Jenkins. The idea is that very few of our contributors are going to bother testing on more than one platform, and with Windows often emerging from our list of supported platforms as the most problematic one, what seems to happens on regular basis, for patches aimed at core, is that while those work splendidly on anything POSIX, as soon as you test with Windows, you get issues of various severity to address. And most of the time, this means that someone, who isn't the original patch submitter, ends up having to smooth things up there. But this is not limited to Windows. We maintainers are also supposed to check every single patch against all platforms, before committing it, to make sure that compilation isn't broken. And as you know, this is a very tedious process, that could benefit from automation, even more so as we now have additional platforms such as *BSD to support. Hopefully, if we can automate the builds for each submitted patch, for at least the MinGW, Linux, BSD and Darwin (Does there exist X-compilers for Darwin?), and let the contributors address the errors/warnings themselves, it should both help spread the workload and increase the quality of what we deliver. And I'm also hoping we can set something up with Wine+WDK or Wine+cygwin, alongside MinGW X-compilation, to bring the pain of compiling anything for native Windows to all the good people who otherwise have a convenient excuse for ignoring it... But the whole idea really is to automate and bring cross-platform build checks to every libusbx contributor, since contributors (and maintainers) are unlikely to conduct these on their own. The one way I see to consistently achieve that is if we have gerrit+Jenkins. Regards, /Pete ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
