Thanks for these patches. Just a couple points so far: On 2012.08.20 22:10, Hans de Goede wrote: > + __u32 caps;
Are stdint.h and the kernel expected to be potentially out of sync with regards to what constitutes an 32 bit unsigned integer, or could we not use the much more universal uint32_t there, especially as that's what we use everywhere else? The rationale would be that even if __u32 is what the kernel prefers, we're building a user library. Also, with regards to the second patch, since we're going to divide by it: > + bulk_buffer_len = transfer->length; I'm not seeing much validation being done in fill_bulk_transfer() and submit_transfer() to ensure that transfer->length is never zero. Isn't that something we should take some provisions for? Apart from that, these 2 patches look good to me. Regards, /Pete PS: Be minfdul to mention 'libusbx' rather than 'libusb' in the patch description ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
