On Tue, Oct 16, 2012 at 09:15:43PM +0800, Xiaofan Chen wrote: > On Tue, Oct 16, 2012 at 3:07 PM, Greg Kroah-Hartman > <gre...@linuxfoundation.org> wrote: > > On Tue, Oct 16, 2012 at 09:57:16AM +0800, Xiaofan Chen wrote: > >> Now usbutils git almost builds successfully out of the box under > >> Mac OS Xand Cygwin (using libusbx). Just wondering if you can > >> accept the minor fix for Mac OS X and suggest a way to fix > >> cygwin build. > >> > >> For Cygwin, there is a conflict with Cygwin's w32api package. > >> > >> DATADIR conflicts with MinGW and cydwin's <objidl.h> in their > >> w32api package. > >> http://caca.zoy.org/changeset/3404 > >> > >> typedef enum tag DATADIR { > >> DATADIR_GET=1, > >> DATADIR_SET > >> } DATADIR; > >> > >> I do not know the proper fix, so I just temporarily change > >> objidl.h to > >> > >> typedef enum tag DATADIR { > >> DATADIR_GET=1, > >> DATADIR_SET > >> } DATADIR1; > >> > >> After that I can build usbutils. > > > > Might it just be easier to patch usbutils to be something like > > USB_IDS_DATADIR instead when building on these systems? > > > > Good idea. Here is the patch based on your suggestion and > it works fine.
<snip patch> That's nice, but I can't accept it as there are lots of distro-specific build stuff that assume we are calling this DATADIR, and I don't want to break them. I suggest keeping this patch for whatever you are using to bundle usbutils for os-x and cygwin. thanks, greg k-h ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
