On 2013.05.20 17:06, Nathan Hjelm wrote: > On May 20, 2013, at 09:51 AM, Toby Gray <toby.g...@realvnc.com> wrote: >> I've attached a handful of patches of changes needed to get WinCE >> building (I've not tried it on hardware yet). I suspect that people will >> have strong opinions on the first patch which creates poll_posix.c.
Actually, even if the new source will be rather small, I think it'll make our implementation cleaner (especially as we already have a poll_posix.h anyway, that used to #define usbi_pipe), so with Nathan's reservations below, I'm +1 on this one. >> Hopefully the other patches aren't as controversial. They look good to me. > If we want to abstract calls to pipe why not 1) make usbi_pipe take an > option as to whether the pipe should be blocking or non-blocking, Seconded. > and 2) > change the one call to pipe to be a call to usbi_pipe instead of using > #define? Maybe I'm missing something there. Would we still have a naked call to pipe anywhere on POSIX after this patch is applied? If there is one, then I also agree with what Nathan says, but I'm not sure what section of code we're talking about. As far as I can see, usbi_io_init() in io.c is already using usbi_pipe(). Regards, /Pete ------------------------------------------------------------------------------ AlienVault Unified Security Management (USM) platform delivers complete security visibility with the essential security capabilities. Easily and efficiently configure, manage, and operate all of your security controls from a single console and one unified framework. Download a free trial. http://p.sf.net/sfu/alienvault_d2d _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
