On May 21, 2013, at 4:19 AM, Toby Gray <toby.g...@realvnc.com> wrote:
> On 21/05/13 00:24, Nathan Hjelm wrote: >>>> and 2) >>>> change the one call to pipe to be a call to usbi_pipe instead of using >>>> #define? >>> Maybe I'm missing something there. >>> >>> Would we still have a naked call to pipe anywhere on POSIX after this >>> patch is applied? >>> If there is one, then I also agree with what Nathan says, but I'm not >>> sure what section of code we're talking about. As far as I can see, >>> usbi_io_init() in io.c is already using usbi_pipe(). >> There are no naked calls to pipe except in the darwin backend so I don't >> know why the #define was done as it shouldn't be necessary. > > I'm sorry but I don't understand which #define you're talking about. > Prior to my changes there was a #define of usbi_pipe to pipe. My change > removed that and made usbi_pipe a function wrapping a call to pipe() and > setting the pipe as non-blocking. > > Is it that #define or a different #define you are referring to? Ack, nevermind. I see that you actually removed a #define not added one. -Nathan ------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_may _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
