Hi, Thanks for the review!
On 06/18/2013 11:49 PM, Pete Batard wrote: > Nothing much to report on that one. > > On 2013.06.13 21:39, Hans de Goede wrote: >> + * <tt>dev</tt> is 0, otherwise the kernel driver will be re-attached when >> you >> + * release the interface(s)! > > I would just avoid exclamation marks in comment (which is something I > removed from the strerror() patch on comments that mentioned UTF-8). The > worst that can happen here is someone will notice that the kernel driver > was unexpectedly reattached, which isn't what I would call a hair > raising situation. Of course, that's just my preference. > Fixed. >> + * \see libusb_set_auto_detach_kernel_driver() > > A \ref might be welcome here, especially if we invite our users to look > at another function call? (x3 as this is done in 3 separate comments) doxygen automatically adds refs to functions if you use them in the form of: func_name(), at least my version automatically turns all these \see comments into links to the function descriptions. Regards, Hans ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
