Hi, On 09/11/2013 04:10 PM, Nathan Hjelm wrote: > > On Sep 11, 2013, at 7:15 AM, Nathan Hjelm <hje...@me.com> wrote: > >> One question. Would it make sense to add an additional transfer type for >> stream transfers? The stream_id field is not set to 0 by >> libusb_fill_bulk_transfer so I can not reliably tell if a transfer is a >> stream transfer in the backend. I need a reliable way to detect stream >> transfers so I can switch APIs. > > So, if I can add LIBUSB_TRANSFER_TYPE_STREAM I have a complete > implementation. It compiles but needs testing.
If possible I would like to avoid making this a new transfer type. And I think we can avoid this, above you wrote: "The stream_id field is not set to 0 by libusb_fill_bulk_transfer" This is true, but it is set to 0 by libusb_alloc_transfer, so it will always be 0 for non stream transfer, unless an app re-uses a transfer changing it from a bulk-stream one into a regular one. Also note that we could simply change libusb_fill_bulk_transfer to zero out the stream-id. > One more thing. I think we should make the stream id either a uint32_t or > unsigned int. It can never be negative and stream id 0 is not a valid stream. I've no objection to changing it into an uint32_t. Regards, Hans ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
