On Sep 12, 2013, at 6:35 AM, Hans de Goede <hdego...@redhat.com> wrote:
> Hi, > > On 09/11/2013 11:04 PM, Hans de Goede wrote: >> Hi, >> >> On 09/11/2013 04:10 PM, Nathan Hjelm wrote: >>> >>> On Sep 11, 2013, at 7:15 AM, Nathan Hjelm <hje...@me.com> wrote: >>> >>>> One question. Would it make sense to add an additional transfer type for >>>> stream transfers? The stream_id field is not set to 0 by >>>> libusb_fill_bulk_transfer so I can not reliably tell if a transfer is a >>>> stream transfer in the backend. I need a reliable way to detect stream >>>> transfers so I can switch APIs. >>> >>> So, if I can add LIBUSB_TRANSFER_TYPE_STREAM I have a complete >>> implementation. It compiles but needs testing. >> >> If possible I would like to avoid making this a new transfer type. >> And I think we can avoid this, above you wrote: >> "The stream_id field is not set to 0 by libusb_fill_bulk_transfer" >> >> This is true, but it is set to 0 by libusb_alloc_transfer, so it will >> always be 0 for non stream transfer, unless an app re-uses a transfer >> changing it from a bulk-stream one into a regular one. >> >> Also note that we could simply change libusb_fill_bulk_transfer to >> zero out the stream-id. > > Sleeping on this a night, a withdraw my objection against having > a LIBUSB_TRANSFER_TYPE_STREAM (note I would like to see it called > LIBUSB_TRANSFER_TYPE_BULK_STREAM) if that makes life easier for other > platforms. We should make a decision on this before finalizing the API. It isn’t ideal but it does make the code more reliable. I have the the type and the darwin backend for streams implemented in my tree. See https://github.com/hjelmn/libusbx/tree/upstream-stream -Nathan ------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk _______________________________________________ libusbx-devel mailing list libusbx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/libusbx-devel
