Hi Manuel,
Regarding the addition of config.h into the testlib.c in b86964a
<https://github.com/libusbx/libusbx/commit/b86964a>, what values were
you needing to pass? Was it just _WIN32?
Regards,
Toby
On 10/10/13 02:02, Manuel Francisco Naranjo wrote:
>
> Pete,
>
> Don't worry on sounding harsh, I agree with the styling issues, my bad
> I missed those changes while reviewing what to stage and what not, btw
> I discovered git add -p, git commit -p and git stash -p thanks to
> this, very powerful, that's why you are seen those style issues.
>
> * b8d13f2 <https://github.com/libusbx/libusbx/commit/b8d13f2> :
> don't worry about this one, I will check the style on this commit,
> and also in any other missing, I only worried about windows_usb.{c,h}
> * 7b4eaa9 <https://github.com/libusbx/libusbx/commit/7b4eaa9> : this
> was necessary to keep tracing library cleanup when not creating a
> different context, I agree this shouldn't be part of the branch,
> but it was a feature I needed to figure out where I was leaking
> devices while still writting the code that's why it was still
> there. I think this is a different conversation.
> * b86964a <https://github.com/libusbx/libusbx/commit/b86964a> : it
> was necessary for mingw building when using my own build tools, as
> I didn't wanted to pass those values through compiler arguments,
> it makes more sense to use the autogenerated config.h
> * 3de7d1d <https://github.com/libusbx/libusbx/commit/3de7d1d> :
> declaring those type values was necessary to get mingw building as
> WINVER and /WIN/WINNT aren't defined, but you are right as I'm
> referencing the A version and not the subfixed one I can just rely
> on PTSTR which should be defined.
> * a3f315d <https://github.com/libusbx/libusbx/commit/a3f315d> : I
> can change to bool, about the arguments you mean lines like 981,
> 982 on the resulting code? You prefer code without argument
> comments? If so I can make those one line, otherwise how you want
> me to put the comments?
> * dfa1d55 <https://github.com/libusbx/libusbx/commit/dfa1d55> and
> c94f9d5 <https://github.com/libusbx/libusbx/commit/c94f9d5> : ok
> makes sense, just wanted to keep track on the changes someone
> suggested for VS2012.
>
> I'll do the suggested fixes and get back to you by the end of the week.
>
> Regards,
> Manuel
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/libusbx/libusbx/issues/9#issuecomment-26021911>.
>
---
Reply to this email directly or view it on GitHub:
https://github.com/libusbx/libusbx/issues/9#issuecomment-26121465------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60134071&iu=/4140/ostg.clktrk
_______________________________________________
libusbx-devel mailing list
libusbx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/libusbx-devel
