On Fri, Apr 05, 2019 at 05:45:10PM +0200, Andrea Bolognani wrote: > On Fri, 2019-04-05 at 17:38 +0200, Andrea Bolognani wrote: > > On Fri, 2019-04-05 at 16:12 +0100, Daniel P. Berrangé wrote: > > > Instead of duplicating javascript in every single page, put it in a > > > standalone file which can be cached by the browser. > > > > > > Signed-off-by: Daniel P. Berrangé <berra...@redhat.com> > > > --- > > > docs/Makefile.am | 1 + > > > docs/main.js | 25 +++++++++++++++++++++++++ > > > docs/page.xsl | 35 +++-------------------------------- > > > 3 files changed, 29 insertions(+), 32 deletions(-) > > > create mode 100644 docs/main.js > > > > Reviewed-by: Andrea Bolognani <abolo...@redhat.com> > > Actually, not so fast: you've moved the existing JavaScript code > to docs/main.js instead of js/docs/main.js, which is of course > completely wrong. Please fix that before pushing.
Opps, squashed that into the 3rd patch by mistake. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
