On Thu, 2019-04-11 at 12:24 +0100, Daniel P. Berrangé wrote:
> On Fri, Apr 05, 2019 at 05:54:41PM +0200, Andrea Bolognani wrote:
> > On Fri, 2019-04-05 at 16:12 +0100, Daniel P. Berrangé wrote:
> > > @@ -91,4 +92,10 @@
> > > float: none;
> > > margin-bottom: 2em;
> > > }
> > > + #advancedsearch {
> > > + margin-top: 4em;
> > > + border: 0px;
> > > + background: white;
> > > + color: black;
> > > + }
> > > }
> >
> > Oh boy, what is even going on with indentation in this file? It's
> > one most insane indentation styles I've ever seen. Your additions
> > are entirely consistent with existing code, though, so I'll just
> > look the other way and try to forget what I've just witnessed.
>
> It isn't that insane - it is just using tabs so it appears wierd when
> your tab indent < 8.
The problem is not that it uses tabs, but that it *mixes* spaces
and tabs:
<4 spaces>#advancedsearch {
<1 tab>margin-top:4em;
<1 tab>border: 0px;
<1 tab>background: white;
<1 tab>color: black;
<4 spaces>}
Using either tabs or spaces for indentation (not alignment!) is
fine in my book, but you should never, *ever* mix the two or you'll
end up with, well, the mess above.
> We should just extend our no-tabs checking to
> cover the CSS too.
Sounds good to me!
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list
