s/suport/support in the subject actually, that makes the subject a bit long; how about just:
s/suport for // On 01/25/2012 09:58 AM, Laine Stump wrote: > This patch addresses: https://bugzilla.redhat.com/show_bug.cgi?id=781562 Always fun to finally get to the real driver of the series. > > Along with the "rombar" option that controls whether or not a boot rom > is made visible to the guest, qemu also has a "romfile" option that > allows specifying a binary file to present as the ROM BIOS of any > emulated or passthrough PCI device. This patch adds support for > specifying romfile to both passthrough PCI devices, and emulated > network devices that attach to the guest's PCI bus (just about > everything other than ne2k_isa). > > One example of the usefulness of this option is described in the > bugzilla report: 82576 sriov network adapters don't provide a ROM BIOS > for the cards virtual functions (VF), but an image of such a ROM is > available, and with this ROM visible to the guest, it can PXE boot. > > In libvirt's xml, the new option is configured like this: > > <hostdev> > ... > <rom file='/etc/fake/boot.bin'/> > ... > </hostdev > > (similarly for <interface>). > --- > docs/formatdomain.html.in | 22 ++++++++++++++++------ > docs/schemas/domaincommon.rng | 19 +++++++++++++------ > src/conf/domain_conf.c | 37 ++++++++++++++++++++++--------------- > src/conf/domain_conf.h | 1 + > src/qemu/qemu_command.c | 8 +++++--- > 5 files changed, 57 insertions(+), 30 deletions(-) See my amended review of 5/6 about moving the specific tests for this new XML into this patch. Beyond those nits, ACK. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
