On 04/02/14 05:04, Eric Blake wrote: > Now that we have a dedicated type for representing a disk source, > we might as well parse and format directly into that type instead > of piecemeal into pointers to members of the type. > > * src/conf/domain_conf.h (virDomainDiskSourceDefFormatInternal) > (virDomainDiskSourceDefParse): Rename... > (virDomainDiskSourceFormat, virDomainDiskSourceParse): ...and > compress signatures. > * src/conf/domain_conf.c (virDomainDiskSourceParse) > (virDomainDiskSourceFormat): Rewrite to use common struct. > (virDomainDiskSourceDefFormat): Delete. > (virDomainDiskDefParseXML, virDomainDiskDefFormat): Update > callers. > * src/conf/snapshot_conf.c (virDomainSnapshotDiskDefParseXML) > (virDomainSnapshotDiskDefFormat): Likewise. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > --- > src/conf/domain_conf.c | 139 > ++++++++++++++++++----------------------------- > src/conf/domain_conf.h | 24 ++------ > src/conf/snapshot_conf.c | 17 +----- > 3 files changed, 62 insertions(+), 118 deletions(-) >
ACK, this fixes my suggestion in one of the previous patches Peter
signature.asc
Description: OpenPGP digital signature
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list