Updates:
Labels: -Patch-review Patch-new
Comment #86 on issue 3255 by [email protected]: \with-dimensions doesn't
affect the overall size of a TextScript
http://code.google.com/p/lilypond/issues/detail?id=3255
There was a previous patch set, reviewed up to comment 23 above, that did
*not* "use the stencil's expression (expr_) in order to contain data
influencing layout."
No-one had any complaints about that patch set (except that a naming choice
was discussed later). The reason I didn't push it was in case people
combined a \with-dimensions stencil with a skylined stencil; the issue 2148
patch looks only in the expression (expr_) for data to build the skylines,
so skylines would not find the data supplied by the user after
\with-dimensions.
Searching Mutopiaproject and the docs for \with-dimensions, \pad-to-box,
etc., all uses I found use a \with-dimensions stencil alone, or wrap it in
a \box or something that preserves the requested dimensions, as in {
\whiteout \pad-around #0.5 "text" } So the patch from comment 20 works
fine for all real use cases.
I rebased and changed that one name as suggested. Let's patchy-check and
push.
https://codereview.appspot.com/9295044/
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings
