http://codereview.appspot.com/4643067/diff/15002/input/regression/phrasing-slur-multiple.ly File input/regression/phrasing-slur-multiple.ly (right):
http://codereview.appspot.com/4643067/diff/15002/input/regression/phrasing-slur-multiple.ly#newcode12 input/regression/phrasing-slur-multiple.ly:12: altPhSlur = #(ly:export (make-music 'PhrasingSlurEvent 'span-direction START 'spanner-id "alt")) remove ly:export (identifiers don't need it; it's only useful for exporting scheme code directly inside a music block) http://codereview.appspot.com/4643067/diff/15002/input/regression/phrasing-slur-multiple.ly#newcode13 input/regression/phrasing-slur-multiple.ly:13: altPhSlurEnd = #(ly:export (make-music 'PhrasingSlurEvent 'span-direction STOP 'spanner-id "alt")) remove ly:export http://codereview.appspot.com/4643067/diff/15002/input/regression/slur-multiple.ly File input/regression/slur-multiple.ly (right): http://codereview.appspot.com/4643067/diff/15002/input/regression/slur-multiple.ly#newcode12 input/regression/slur-multiple.ly:12: altSlur = #(ly:export (make-music 'SlurEvent 'span-direction START 'spanner-id "alt")) remove ly:export http://codereview.appspot.com/4643067/diff/15002/input/regression/slur-multiple.ly#newcode13 input/regression/slur-multiple.ly:13: altSlurEnd = #(ly:export (make-music 'SlurEvent 'span-direction STOP 'spanner-id "alt")) remove ly:export http://codereview.appspot.com/4643067/diff/15002/lily/phrasing-slur-engraver.cc File lily/phrasing-slur-engraver.cc (right): http://codereview.appspot.com/4643067/diff/15002/lily/phrasing-slur-engraver.cc#newcode52 lily/phrasing-slur-engraver.cc:52: vector<Stream_event *> start_events_; why not use Drul_array<vector<Stream_event * > > events_; to encompass start & end together? http://codereview.appspot.com/4643067/diff/15002/lily/phrasing-slur-engraver.cc#newcode171 lily/phrasing-slur-engraver.cc:171: SCM scm_id = ev->get_property ("spanner-id"); robust_scm2string (ev->get_property ("spanner-id"), ""); http://codereview.appspot.com/4643067/diff/15002/lily/phrasing-slur-engraver.cc#newcode176 lily/phrasing-slur-engraver.cc:176: for (int j = slurs_.size () - 1 ; j
= 0; j--)
for (vsize j = slurs_.size (); j--;) http://codereview.appspot.com/4643067/diff/15002/lily/phrasing-slur-engraver.cc#newcode192 lily/phrasing-slur-engraver.cc:192: SCM scm_id = ev->get_property ("spanner-id"); robust_scm2string (ev->get_property ("spanner-id"), ""); http://codereview.appspot.com/4643067/diff/15002/lily/slur-engraver.cc File lily/slur-engraver.cc (right): http://codereview.appspot.com/4643067/diff/15002/lily/slur-engraver.cc#newcode171 lily/slur-engraver.cc:171: SCM scm_id = ev->get_property ("spanner-id"); robust_scm2string (ev->get_property ("spanner-id"), ""); http://codereview.appspot.com/4643067/diff/15002/lily/slur-engraver.cc#newcode176 lily/slur-engraver.cc:176: for (int j = slurs_.size () - 1 ; j >= 0; j--) for (vsize j = slurs_.size (); j--;) http://codereview.appspot.com/4643067/diff/15002/lily/slur-engraver.cc#newcode192 lily/slur-engraver.cc:192: SCM scm_id = ev->get_property ("spanner-id"); robust_scm2string (ev->get_property ("spanner-id"), ""); http://codereview.appspot.com/4643067/diff/15002/lily/slur.cc File lily/slur.cc (right): http://codereview.appspot.com/4643067/diff/15002/lily/slur.cc#newcode501 lily/slur.cc:501: "spanner-id " belongs in spanner-interface http://codereview.appspot.com/4643067/diff/15002/ly/grace-init.ly File ly/grace-init.ly (right): http://codereview.appspot.com/4643067/diff/15002/ly/grace-init.ly#newcode3 ly/grace-init.ly:3: graceSlur = #(ly:export (make-music 'SlurEvent 'span-direction START 'spanner-id "grace")) remove ly:export http://codereview.appspot.com/4643067/diff/15002/ly/grace-init.ly#newcode4 ly/grace-init.ly:4: graceSlurEnd = #(ly:export (make-music 'SlurEvent 'span-direction STOP 'spanner-id "grace")) remove ly:export http://codereview.appspot.com/4643067/diff/15002/ly/grace-init.ly#newcode15 ly/grace-init.ly:15: s1*0\graceSlur \startGraceSlur ? http://codereview.appspot.com/4643067/diff/15002/ly/grace-init.ly#newcode19 ly/grace-init.ly:19: s1*0\graceSlurEnd \stopGraceSlur ? http://codereview.appspot.com/4643067/diff/15002/scm/define-music-properties.scm File scm/define-music-properties.scm (right): http://codereview.appspot.com/4643067/diff/15002/scm/define-music-properties.scm#newcode170 scm/define-music-properties.scm:170: (spanner-id ,string? "Identifier to distinguish concurrent spanners") spanners.") http://codereview.appspot.com/4643067/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel