2011/8/6 m...@apollinemike.com <m...@apollinemike.com>: > On Aug 6, 2011, at 11:09 AM, lemniskata.bernoull...@gmail.com wrote: >> i tried writing a review, but i don't understand what's going on here. >> Can you add some comments to the code? > > The function fit_factor pushes up the height of a slur if there is an > extra-encompass-object in the way. My change makes this function ignore all > extra-encompass-objects close to the extremes of a slur, as these objects > have a tendency to push a slur up disproportionately high. These objects are > still penalized in the scoring, which results in their avoidance if possible.
Thanks. Could you add this to the source as a comment? This sounds reasonable, however i still have a hard time reading this code because variable names aren't descriptive... What dz_unit, dz_perp, curve_xext are? What pext.intersect (curve_xext) does? cheers, Janek _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
