http://codereview.appspot.com/4810072/diff/7001/input/regression/slur-height-capping.ly File input/regression/slur-height-capping.ly (right):
http://codereview.appspot.com/4810072/diff/7001/input/regression/slur-height-capping.ly#newcode5 input/regression/slur-height-capping.ly:5: towards the edges of the slurs. said objects are thus ignored. On 2011/08/08 03:52:52, Keith wrote:
"said objects are thus ignored" confuses me. You should say something to let us easily check if the test passes;
maybe "the
two slurs should be similar in shape"
Done. http://codereview.appspot.com/4810072/diff/7001/input/regression/slur-height-capping.ly#newcode10 input/regression/slur-height-capping.ly:10: \relative c' { On 2011/08/08 03:52:52, Keith wrote:
Even after the bug-fix, this output looks odd enough that people might
waste
time wondering if something is wrong. I'd drop it; the second test is enough.
Done. http://codereview.appspot.com/4810072/diff/7001/lily/slur-configuration.cc File lily/slur-configuration.cc (right): http://codereview.appspot.com/4810072/diff/7001/lily/slur-configuration.cc#newcode105 lily/slur-configuration.cc:105: if ((pext.is_empty () On 2011/08/08 03:52:52, Keith wrote:
You might move your code, and if (close_to_edge) continue; up to line 94, because your test is conceptually independent of the
pext
computation.
Done. http://codereview.appspot.com/4810072/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
