New Draft. Before I push this (and as Neil has just done an LSR update) do I still need to run makelsr.py before applying this patch once it has been approved?
I have removed one snippet from both dirs (snippets/new and snippets). I'll get someone to remove the snippet from the LSR too. http://codereview.appspot.com/4837050/diff/15001/Documentation/music-glossary.tely File Documentation/music-glossary.tely (right): http://codereview.appspot.com/4837050/diff/15001/Documentation/music-glossary.tely#newcode2114 Documentation/music-glossary.tely:2114: \compoundMeter #'((3 8) (2 8) (4 8)) On 2011/08/07 15:24:44, Trevor Daniels wrote:
\compoundMeter #'((3 8) (2 8) (3 8))
Done. http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1546 Documentation/notation/rhythms.itely:1546: @code{\scaleDurations} function in each staff to the common time On 2011/08/07 15:24:44, Trevor Daniels wrote:
... function to scale the durations of the notes in each staff ...
Done. http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1555 Documentation/notation/rhythms.itely:1555: shown durations are multiplied by 3/5 -- as 3/5 * 10/8 = 3/4. It may be On 2011/08/07 15:24:44, Trevor Daniels wrote:
I prefer brackets to show these parenthetical comments: (because 2/3 * 9/8 = 3/4)
I have no strong feelings either way. So Done. http://codereview.appspot.com/4837050/diff/15001/Documentation/notation/rhythms.itely#newcode1643 Documentation/notation/rhythms.itely:1643: come before it indicate the beat value. On 2011/08/07 15:24:44, Trevor Daniels wrote:
I think it's clearer to say top and bottom of the time signature: ... last number in the list is placed at the bottom of the time
signature and
the numbers that come before it are placed as a summation at the top.
All but
the last number indicate the stress groupings and sum to the duration
of the
measure.
hmmm..I still think that is a bit awkward - I'm not sure 'summation' comes over well for non-native English speakers looking at the NR. I also don't feel the last sentence is necessary if the @lilyponds are good enough (that and we talk about beaming anyway later). See what you think of my very simple change. http://codereview.appspot.com/4837050/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
