I figured not making a regtest just cuz there will already be little changes to several regtests. But, I can certainly add one.
Cheers, MS http://codereview.appspot.com/4898060/diff/1/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (right): http://codereview.appspot.com/4898060/diff/1/lily/ledger-line-spanner.cc#newcode89 lily/ledger-line-spanner.cc:89: continue; On 2011/08/18 12:16:50, hanwenn wrote:
can't you check poss.find(max(0, lincount - *it)) ?
I don't understand what this is supposed to do ; in which cases do you
want to
skip ledger creation?
Good call - I can do this. It skips over all ledger lines that already have a note on them, thus avoiding duplicates. http://codereview.appspot.com/4898060/diff/1/lily/ledger-line-spanner.cc#newcode337 lily/ledger-line-spanner.cc:337: poss[(Direction) sign (pos)].insert (sign (pos) * int (rint (pos - staff_extent[Direction (sign (pos))])) / 2); On 2011/08/18 12:16:50, hanwenn wrote:
have you tried if you can change sign() to return a Direction ?
No - I'll have a look. http://codereview.appspot.com/4898060/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
