Thanks Carl, I've made these changes, and I've also made a corresponding patch for changes.tely, but I don't think I have permission to upload new patch sets for either to this issue since it says "Can't Edit" at the top-left - can you give me permission? (If not, this is yet another reason Rietveld sucks. It all seems way too locked down to me.)
In lieu of a patch set, the amended patch series is available here (freshly rebased on master): https://github.com/aspiers/lilypond/commits/jazz http://codereview.appspot.com/5320074/diff/14001/input/regression/chord-additional-pitch-prefix.ly File input/regression/chord-additional-pitch-prefix.ly (right): http://codereview.appspot.com/5320074/diff/14001/input/regression/chord-additional-pitch-prefix.ly#newcode1 input/regression/chord-additional-pitch-prefix.ly:1: \version "2.15.16" On 2011/11/05 14:33:32, Carl wrote:
Will need to be adjusted when it's ready to commit. Right now, it
should be
2.15.17.
Version of new snippets is always one greater than the current release
version. Done. http://codereview.appspot.com/5320074/diff/14001/scm/define-context-properties.scm File scm/define-context-properties.scm (right): http://codereview.appspot.com/5320074/diff/14001/scm/define-context-properties.scm#newcode380 scm/define-context-properties.scm:380: (minorChordModifier ,markup? "How should minor chords be formatted On 2011/11/05 14:33:32, Carl wrote:
I'd prefer "Markup displayed following the root for a minor chord."
Done. http://codereview.appspot.com/5320074/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
