Great work David. I like how \harmonic works properly for single notes now. :)
http://codereview.appspot.com/5440084/diff/14005/lily/music-scheme.cc File lily/music-scheme.cc (right): http://codereview.appspot.com/5440084/diff/14005/lily/music-scheme.cc#newcode79 lily/music-scheme.cc:79: "Is @var{obj} a proper (non-rhythmic) event object?") I'd be much happier if there were a separate ly:post-event? predicate. If I see ly:event? I'd expect it to return true for all events. http://codereview.appspot.com/5440084/diff/14005/lily/music.cc File lily/music.cc (right): http://codereview.appspot.com/5440084/diff/14005/lily/music.cc#newcode164 lily/music.cc:164: (void) music_list_to_relative (get_property ("articulations"), last, true); Since this is only used in TrillSpanEvent, wouldn't it be better to have a callback specific to rhythmic music which does this instead of checking it every time? Ideally, we'd have a separate event for the trill pitch, then we wouldn't need to do this at all if it were kept out of 'articulations (and it would have the added benefit of correct origin info). http://codereview.appspot.com/5440084/diff/14005/scm/define-music-display-methods.scm File scm/define-music-display-methods.scm (right): http://codereview.appspot.com/5440084/diff/14005/scm/define-music-display-methods.scm#newcode141 scm/define-music-display-methods.scm:141: (define (post-event? m) This just duplicates the code for the exported predicate. http://codereview.appspot.com/5440084/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
