On 2012/01/24 22:47:31, Neil Puttock wrote:
Great work David. I like how \harmonic works properly for single
notes now. :)
As opposed to an earlier version of the patch or to LilyPond's previous behavior? All of your code comments are quite spot on and touch some sore spots that I decided would make more sense to tackle independently in order not to introduce too many incompatibilities in one go. ly:event? definitely has to go one way or the other. Its original definition at one time was equivalent to mus-is-of-type? 'event, but while it was used for recognizing post-events from a smaller set than what the predicate is used for testing now, that was never really correct. It is used in many places though, and it seems weird to check for ly:music? but only for post-event? even though the latter does not really require C++ to define. http://codereview.appspot.com/5440084/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel