On 2014/06/15 07:46:22, marc wrote:
Hi Harm,
great work, mostly LGTM, just two small nitpicks.
https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm
File scm/fret-diagrams.scm (right):
https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm#newcode119
scm/fret-diagrams.scm:119: ;; parantheses
typo: parentheses or -is
done
https://codereview.appspot.com/102450043/diff/1/scm/fret-diagrams.scm#newcode1096
scm/fret-diagrams.scm:1096: The values for @var{string-number},
@var{fret-number}, and @var{finger}
This description is not precise IMHO. The first values have to be in
that order.
Hope it's better now.
Do I have to code a value for finger before I use one ore more of the
optional
arguments?
no
Would (place-fret 1 1 parenthesized) work?
yes, it will work
https://codereview.appspot.com/102450043/
_______________________________________________
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
