https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly File input/regression/font-expert-selection.ly (right):
https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode33 input/regression/font-expert-selection.ly:33: ;; definition, irregardless of the name given. (Only before the score? regardless https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode66 input/regression/font-expert-selection.ly:66: #(define fonts #(define fonts (make-palladio-dejavu-tree (/ myStaffSize 20))) https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode77 input/regression/font-expert-selection.ly:77: \markup \huge { \sans "xxx sans xxx" "xxx serif xxx" \typewriter "xxx monospace xxx" } \markup \huge { \sans "xxx sans xxx" "xxx serif xxx" \typewriter "xxx monospace xxx" } https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode81 input/regression/font-expert-selection.ly:81: \new Staff << `\new Staff << >>' is redundant, just do `\context Voice' https://codereview.appspot.com/108700043/diff/80001/input/regression/font-expert-selection.ly#newcode90 input/regression/font-expert-selection.ly:90: \override LyricText . font-family = #'condensed LyricText.font-family https://codereview.appspot.com/108700043/diff/80001/scm/font.scm File scm/font.scm (right): https://codereview.appspot.com/108700043/diff/80001/scm/font.scm#newcode285 scm/font.scm:285: (let ((n (make-font-tree-node 'font-encoding 'fetaMusic))) I'd find this formatting easier to read: (let ((n (make-font-tree-node 'font-encoding 'fetaMusic))) (add-music-fonts n "emmentaler" 'feta feta-design-size-mapping factor) (for-each (lambda (L) (let* ((lily-family (list-ref L 0)) (shape (list-ref L 1)) (series (list-ref L 2)) (scale (if (= (length L) 5) (list-ref L 4 ) 1.0)) (desc (string-append (list-ref L 3) " " (number->string (* scale (ly:pt 12)))))) (add-expert-node n lily-family shape series desc))) font-spec-list) n)) https://codereview.appspot.com/108700043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel