On 2016/08/04 21:23:12, ht wrote:
LGTM except for a small question (still) about the process_music
logic.
Also, I noticed the following definition in scm/midi.scm:
;; 90 == 90/127 == 0.71 is supposed to be the default value ;; urg: we should set this at start of track (define-public dynamic-default-volume 0.71)
It would seem to me that the Dynamic_performer should use the scheme variable dynamic-default-volume as the default, rather than a hard-coded lookup of mf. In my opinion, we should not have any constants that a user might want to change hard-coded in C++, because then the user can't change them. I'd also be delighted to have the default value of dynamic-default-volume be set to the lookup of mf in scm/midi.scm https://codereview.appspot.com/308890043/ _______________________________________________ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
