On 2020/01/29 15:36:59, fedelogy wrote: > LGTM > > Just two thoughts: > > 1. I'm not sure why you suggest how to set the root password, as the dev user > can get admin privileges via sudo.
Well, I just thought that it would be bad idea for >any< Linux system to leave the root password unsetted. Maybe the amount of damage that can occur to the host system through the virtualization barrier is small, but at least it minimizes the risk of scrambling your guest system by accident. If you use 'sudo', you have to think about what you type, at least. AFAIK, Ubuntu disables the root account by default, for such reasons. But you could argue that the docs suggest to log in as 'dev', anyway, and if I do want to log in as root, it does not matter if I have to use a password or none. What do you think about disabling the root account? > > 2. While keyboard configuration is a step needed for any non-US contributor, > reconfiguring the locales should be useful only for translators, unless I miss > something. > > Perhaps you could say that these two configurations are optional. One benefit is to have the window manager and the output of localized tools in your own language. But that's not essential, I admit. But I noticed that umlauts are not displayed correctly without configuring the locales. Or am I missing some simpler solution here? https://codereview.appspot.com/561360043/