-----Original Message----- here's my feedback on the implementation: - open() should return -EBUSY in case the device is INUSE, not -EACCES > Sounds reasonable - release() should probably contain BUG_ON(!dev->flag & INUSE), it does only get called by VFS for open file descriptors > Okay. - readv()/writev() don't look like it does the job actually... > Yes, they're only skeletons at the moment. It's a matter of mapping its stuff to the iucv buffer list version of send/receive.
The code looks pretty good overall, except for the coding style which does not fit the Linux Kernel. > Any useful tools to convert? Any plans of merging this into the Linux Kernel? > I'd like to eventually. ---------------------------------------------------------------------- For LINUX-390 subscribe / signoff / archive access instructions, send email to [EMAIL PROTECTED] with the message: INFO LINUX-390 or visit http://www.marist.edu/htbin/wlvindex?LINUX-390
