On Thu, Oct 19, 2017 at 10:17:01AM +0300, Sagi Grimberg wrote: > > >> - if (!kref_get_unless_zero(&ctrl->ctrl.kref)) >> - return -EBUSY; >> + nvme_get_ctrl(&ctrl->ctrl); > > Given that we take this reference before we are protected with > the state change I think this should still be get_unless_zero.
Because we now refcount the device we must have a reference on it when we call the sysfs file for it, and for the fabrics file we have an explicit reference already. So there should not be any need to do the unless_zero. > Maybe we can introduce get_device_unless_zero() for this? I thought about it for the other open coded versions and my decision was that I want to send a patch for it next merge window, but not now to avoid having to coordinate with the driver core tree.
