On Thu, Oct 19, 2017 at 01:02:59PM +0300, Sagi Grimberg wrote: >> By the time we call ->delete_ctrl in nvmf_create_ctrl we must still >> have that reference because we are still in a ->write call and thus >> ->release can't have been called yet. > > Thanks for the clarification. Is it worth a preparatory patch to > change that before the ctrl device integration for change log > clarity?
Well, the ctrl device integration is what enables us to do this. Before that the ctrl refcount could have reached null by the time we call the delete_ctrl method.