Jens Axboe wrote:
> On Wed, Feb 07 2007, Vasily Tarasov wrote:
>
>> Jens Axboe wrote:
>>
>>> On Wed, Feb 07 2007, Vasily Tarasov wrote:
>>>
>>>
>>>> Hello,
>>>>
>>>> At the moment there is no dependencies on header files in blktracer's
>>>> Makefiles,
>>>> and this cause some problems. This tiny patch simply adds needed deps.
>>>>
>>>>
>>> Maybe I'm just Makefile ignorant (and I really am), but why doesn't the
>>> depend cover this?
>>>
>> The problem actually is that I'm using not `make` or `make all`, but
>> just `make blktrace`.
>> And in this case depend target isn't executed... But after your comment
>> I think,
>> that my patch isn't good enough and better way is to use depend... What
>> do you think?
>>
>
> It'd be nice if the depend step was always executed, so we don't risk
> building parts with an out-of-date .h file. So if you can send a patch
> for that, I'll surely take it.
I think such patch should be ok.
Thanks.
--- ./Makefile.make-header 2007-02-07 03:38:39.000000000 +0300
+++ ./Makefile 2007-02-07 04:46:55.000000000 +0300
@@ -5,7 +5,7 @@ PROGS = blkparse blktrace verify_blkpars
LIBS = -lpthread
SCRIPTS = btrace
-all: depend $(PROGS) $(SCRIPTS)
+all: $(PROGS) $(SCRIPTS)
$(MAKE) -C btt
%.o: %.c
@@ -23,6 +23,8 @@ verify_blkparse: verify_blkparse.o
blkrawverify: blkrawverify.o
$(CC) $(ALL_CFLAGS) -o $@ $(filter %.o,$^)
+$(PROGS): | depend
+
docs:
$(MAKE) -C doc all
