Jens Axboe wrote: > On Wed, Feb 07 2007, Vasily Tarasov wrote: > >> Jens Axboe wrote: >> >>> On Wed, Feb 07 2007, Vasily Tarasov wrote: >>> >>> >>>> Jens Axboe wrote: >>>> >>>> >>>>> On Wed, Feb 07 2007, Vasily Tarasov wrote: >>>>> >>>>> >>>>> >>>>>> Hello, >>>>>> >>>>>> At the moment there is no dependencies on header files in blktracer's >>>>>> Makefiles, >>>>>> and this cause some problems. This tiny patch simply adds needed deps. >>>>>> >>>>>> >>>>>> >>>>> Maybe I'm just Makefile ignorant (and I really am), but why doesn't the >>>>> depend cover this? >>>>> >>>>> >>>> The problem actually is that I'm using not `make` or `make all`, but >>>> just `make blktrace`. >>>> And in this case depend target isn't executed... But after your comment >>>> I think, >>>> that my patch isn't good enough and better way is to use depend... What >>>> do you think? >>>> >>>> >>> It'd be nice if the depend step was always executed, so we don't risk >>> building parts with an out-of-date .h file. So if you can send a patch >>> for that, I'll surely take it. >>> >> I think such patch should be ok. >> > > Doesn't quite seem to work, it generates the .depend at the end of the > compile. Hmm perhaps that is ok, as the sources are cleaned before > starting anyway? Yes, it's ok. Look for example at the end of the Makefile:
ifneq ($(wildcard .depend),) include .depend endif If there is no .depend file, dependencies on header files aren't included, and .depend file is only generated after everything is compiled. But that is ok, as the sources are cleaned before starting in such situation. - To unsubscribe from this list: send the line "unsubscribe linux-btrace" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
