> From: Nitin Gupta [mailto:ngu...@vflare.org] > Sent: Friday, July 23, 2010 9:05 AM > To: Dan Magenheimer > Cc: Christoph Hellwig; a...@linux-foundation.org; Chris Mason; > v...@zeniv.linux.org.uk; adil...@sun.com; ty...@mit.edu; > mfas...@suse.com; Joel Becker; matt...@wil.cx; linux- > bt...@vger.kernel.org; linux-ker...@vger.kernel.org; linux- > fsde...@vger.kernel.org; linux-e...@vger.kernel.org; ocfs2- > de...@oss.oracle.com; linux...@kvack.org; jer...@goop.org; > jbeul...@novell.com; Kurt Hackel; npig...@suse.de; Dave Mccracken; > r...@redhat.com; a...@redhat.com; Konrad Wilk > Subject: Re: [PATCH V3 0/8] Cleancache: overview > > On 07/23/2010 08:14 PM, Dan Magenheimer wrote: > >> From: Christoph Hellwig [mailto:h...@infradead.org] > > > >> Also making the ops vector global is just a bad idea. > >> There is nothing making this sort of caching inherently global. > > > > I'm not sure I understand your point, but two very different > > users of cleancache have been provided, and more will be > > discussed at the MM summit next month. > > > > Do you have a suggestion on how to avoid a global ops > > vector while still serving the needs of both existing > > users? > > Maybe introduce cleancache_register(struct cleancache_ops *ops)? > This will allow making cleancache_ops non-global. No value add > but maybe that's cleaner?
Oh, OK, that seems reasonable. Dan -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html