Am Sonntag, 18. März 2012 schrieb Greg Kroah-Hartman:
> On Sat, Mar 17, 2012 at 10:43:25AM +0100, Martin Steigerwald wrote:
> > Hi Greg, Chris, Arne, hi everyone,
> > 
> > Am Freitag, 16. März 2012 schrieb Martin Steigerwald:
> > > Am Donnerstag, 15. März 2012 schrieb Chris Mason:
> > > > On Thu, Mar 15, 2012 at 06:32:19PM +0100, Martin Steigerwald wrote:
> > > > > Am Samstag, 25. Februar 2012 schrieb Arne Jansen:
> > > > > > On 02/24/12 16:51, Martin Steigerwald wrote:
> > > > > > > Am Samstag, 21. Januar 2012 schrieb Martin Steigerwald:
> > > > > > >> Am Samstag, 21. Januar 2012 schrieb Martin Steigerwald:
> > > > > > >>> I still have this with 3.2.0-1-pae - which is a debian kernel
> > > > > > >>> based on 3.2.1.
> > > > > > >>> 
> > > > > > >>> When I do btrfs scrub start / the machine locks immediately
> > > > > > >>> up hard.
> > > > > > >>> 
> > > > > > >>> Then usually on next boot it stops on space_cache enabled
> > > > > > >>> message, but not  the one for /, but the one for /home which
> > > > > > >>> is mounted later.
> > > 
> > > […]
> > > 
> > > > > > >> I now tested scrubbing /home which is a different BTRFS
> > > > > > >> filesystem on the same machine.
> > > > > > >> 
> > > > > > >> Then the scrub is started, scrub status tells me so, but
> > > > > > >> nothing happens, no block in/out activity in vmstat, no CPU
> > > > > > >> related activity in top.
> > > > > > >> 
> > > > > > >> btrfs scrub cancel then hangs, but not the complete machine,
> > > > > > >> only the process.
> > > > > > >> 
> > > > > > >> I had this once on my T520 with the internal Intel SSD 320 as
> > > > > > >> well. The other time it worked.
> > > > > > >> 
> > > > > > >> Well maybe that is due to BTRFS doing something else on my T23
> > > > > > >> now:
> > > > > > >> 
> > > > > > >> deepdance:~>  ps aux | grep ino-cache | grep -v grep
> > > > > > >> root      1992  5.5  0.0      0     0 ?        D    12:15
> > > > > > >> 0:09 [btrfs- ino-cache]
> > > 
> > > […]
> > > 
> > > > > > >> At least it doesn´t lock up hard, so there might really be
> > > > > > >> something strange with /.
> > > > > > > 
> > > > > > > FWIW a btrfs filesystem balance / does work. After this a btrfs
> > > > > > > scrub start / still locks the kernel.
> > > > > > 
> > > > > > Hi Martin,
> > > > > > 
> > > > > > I just sent 2 patches to the list. Could you please test if these
> > > > > > fix your problem with scrub?
> > > > > 
> > > > > I didn´t yet test it but I tried the first balance then scrub stuff
> > > > 
> > > > > again:
> > > > Looks like you're on a 32 bit machine.  The current for-linus branch
> > > > has an important fix for scrub on 32 bit that should solve this.
> > > 
> > > So finally - the machine did make-kpkg over night and complained about
> > > missing Documentation lguest, then I switched off lots from distro
> > > default config and just did the usual make stuff - I was able to scrub
> > > both partitions on that ThinkPad T23:
> > > 
> > > deepdance:~> btrfs scrub status /
> > > scrub status for 2bf5b1dc-1d89-4f0d-a561-1a5551a27275
> > > 
> > >         scrub started at Fri Mar 16 11:56:12 2012 and finished after
> > > 
> > > 741 seconds total bytes scrubbed: 9.62GB with 0 errors
> > > 
> > > deepdance:~> btrfs scrub status /home
> > > scrub status for a600de65-e1ab-4cbf-b150-bbaeaf9fa98d
> > > 
> > >         scrub started at Fri Mar 16 12:00:31 2012 and finished after
> > > 
> > > 1708 seconds total bytes scrubbed: 36.63GB with 0 errors
> > > 
> > > Thanks a lot for fixing this.
> > > 
> > > Tested-by: Martin Steigerwald <mar...@lichtvoll.de>
> > 
> > […]
> > 
> > Would that patch
> > 
> > Btrfs: fix casting error in scrub reada code
> > 
> > http://git.kernel.org/?p=linux/kernel/git/mason/linux-
> > btrfs.git;a=commit;h=a175423c831ea582c06784d1e172d2ce1d79923a
> > 
> > (sorry for line break. KMail insists on it even when I disable line
> > breaks due to the minus sign in the URL.)
> > 
> > that I tested above be something for stable?
> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
> 
> </formletter>

What point of the rules do you refer to? Is it

 - It or an equivalent fix must already exist in Linus' tree (upstream).

?

Or do you want the patch quoted in the mail?

Anyways its not yet in linus tree AFAIR and from my side it was a question 
whether it should be included at all. I thought it might be good ccing you on 
that question already.

Chris, how about this patch for stable once it hits Linus' tree?

Thanks,
-- 
Martin Steigerwald - teamix GmbH - http://www.teamix.de
gpg: 19E3 8D42 896F D004 08AC A0CA 1E10 C593 0399 AE90
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to