On Wed, Oct 03, 2012 at 06:17:53PM +0200, Goffredo Baroncelli wrote: > On 10/03/2012 01:56 PM, Hugo Mills wrote: > > Looks good. Only a few comments, inline. > > > >On Wed, Oct 03, 2012 at 01:43:14PM +0200, Goffredo Baroncelli wrote: [snip] > > Also, use kB, MB, GB, TB for powers-of-ten based units, and KiB, > >MiB, GiB, TiB for powers-of-two based units, please. I don't care > >which you report in, but please do make the distinction. (And note > >that it's kB with a lower case k, but KiB with an upper case K). This > >brings us in line with the relevant ISO and IEEE standards. > > I forgot to reply you when you raised this question the first time. > Even though I am inclined to accept your suggestions, this change is > not related to my patches. My code uses the functions print_sizes(), > which is quite old (about 2008). This function is used in a lot of > places. This suggested to address this issue with another patch.
OK. [snip] > > Why are the field headings here using - where the field headings in > >the first section used _? Should you be using _ in both places? > > 2 persons highlighted that :-( ... I will update the code It's just a niggle, really, but it's an obvious one. Hugo. -- === Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk === PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk --- There is no dark side to the Moon, really. As a matter of --- fact, it's all dark.
signature.asc
Description: Digital signature
