On Fri, Feb 08, 2013 at 01:37:02AM +0100, Ian Kumlien wrote:
> the btrfs command now lists:
> btrfs rescue select-super -s <number> <device>
> Select a superblock
> btrfs rescue dump-super <device>
> Dump a superblock to disk
> btrfs rescue debug-tree [options] <device>
> Debug the filesystem
>
> btrfs-dump-super.c was imported in to cmds-rescue-super-ops.c
>
> This patch integrates all the functionality...
>
> cmds-rescue.c is used to glue cmds-rescue-debug-tree.c,
> cmds-rescue-restore.c and cmds-rescue-super-ops.c together to
> make the source files more managable.
I think btrfs-debug-tree should go under debug -- btrfs debug dump-tree.
Same goes for btrfs-dump-super -- btrfs debug dump-super. These
commands won't help an average user to rescue a single byte, they are
there to help developers. I suppose you can also import btrfs-image
under btrfs debug dump-image.
This leaves the question of whether we want select-super under rescue.
Given that it can easily do more harm than good, it might not be the
best place for it..
Thanks,
Ilya
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
