On Fri, Feb 08, 2013 at 09:57:17PM +0200, Ilya Dryomov wrote: > On Fri, Feb 08, 2013 at 01:37:02AM +0100, Ian Kumlien wrote: > > the btrfs command now lists: > > btrfs rescue select-super -s <number> <device> > > Select a superblock > > btrfs rescue dump-super <device> > > Dump a superblock to disk > > btrfs rescue debug-tree [options] <device> > > Debug the filesystem > > > > btrfs-dump-super.c was imported in to cmds-rescue-super-ops.c > > > > This patch integrates all the functionality... > > > > cmds-rescue.c is used to glue cmds-rescue-debug-tree.c, > > cmds-rescue-restore.c and cmds-rescue-super-ops.c together to > > make the source files more managable. > > I think btrfs-debug-tree should go under debug -- btrfs debug dump-tree. > Same goes for btrfs-dump-super -- btrfs debug dump-super. These > commands won't help an average user to rescue a single byte, they are > there to help developers. I suppose you can also import btrfs-image > under btrfs debug dump-image.
Can I put in a suggestion of using inspect-internal instead? Since we've already got that one already? (But I'm not bothered about debug; either is good). Hugo. > This leaves the question of whether we want select-super under rescue. > Given that it can easily do more harm than good, it might not be the > best place for it.. > > Thanks, > > Ilya -- === Hugo Mills: hugo@... carfax.org.uk | darksatanic.net | lug.org.uk === PGP key: 515C238D from wwwkeys.eu.pgp.net or http://www.carfax.org.uk --- The early bird gets the worm, but the second mouse --- gets the cheese.
signature.asc
Description: Digital signature
