Hello, Jan
[snip]
>>
>> +#include<linux/list.h>
>> +#include<linux/rbtree.h>
>
> I didn't expect the space after "#include" being optional. If it compiles, I'm
> fine with it. With a space, it would look more familiar, though.
I am happy to send V2 to correct this coding style problem.
Thanks very much for reviewing it so carefully!
Thanks,
Wang
>> +
>> /*
>> * ulist is a generic data structure to hold a collection of unique u64
>> * values. The only operations it supports is adding to the list and
>> @@ -34,6 +37,7 @@ struct ulist_iterator {
>> struct ulist_node {
>> u64 val; /* value to store */
>> u64 aux; /* auxiliary value saved along with the val */
>> + struct rb_node rb_node; /* used to speed up search */
>> };
>>
>> struct ulist {
>> @@ -54,6 +58,8 @@ struct ulist {
>> */
>> struct ulist_node *nodes;
>>
>> + struct rb_root root;
>> +
>> /*
>> * inline storage space for the first ULIST_SIZE entries
>> */
>>
>
> Makes a lot of sense. Thanks!
>
> Reviewed-by: Jan Schmidt <list.bt...@jan-o-sch.net>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
