On Tue, April 16, 2013 at 11:20 (+0200), Wang Shilong wrote: > Hello Jan, > >> The function is separated into a preparation part and the three accounting >> steps mentioned in the qgroups documentation. The goal is to make steps two >> and three usable by the rescan functionality. A side effect is that the >> function is restructured into readable subunits. > > > How about renaming the three functions like: > > 1> qgroup_walk_old_roots() > 2> qgroup_walk_new_root() > 3> qgroup_rewalk_old_root() > > I'd like this function to be meaningful, but not just step1,2,3. > Maybe you can think out better function name.
I'd like to keep it like 1, 2, 3, because that matches the documentation in the qgroup pdf and the code has always been documented in those three steps. Thanks, -Jan -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
