On 09/18/2016 04:35 AM, David Sterba wrote:
On Fri, Sep 16, 2016 at 07:56:02PM +0800, Anand Jain wrote:
however here below is the quick example
on the cli usage. Please try out, let me know if I have missed something.
Also would like to mention that a review from the security experts is due,
which is important and I believe those review comments can be accommodated
without major changes from here.
I disagree. Others commented on the crypto stuff, I see enough points to
address that would lead to major changes.
Also yes, thanks for the emails, I hear, per file encryption and inline
with vfs layer is also important, which is wip among other things in the
list.
Implementing the recent vfs encryption in btrfs is ok, it's just feature
parity using an existing API.
As mentioned 'inline with vfs layer' I mean to say to use
fs/crypto KPIs. Which I haven't seen what parts of the code
from ext4 was made as generic KPIs. If that's getting stuff
correct in the encryption related, I think it would here as well.
So you were not talking about the 'fs/crypto' that was merged in 4.6?
Looks like I am out of sync here, looks like I miss understood,
'Implementing the recent vfs encryption in btrfs is ok'
I was ref to fs/crypto
Internal to btrfs - I had challenges to get the extents encoding
done properly without bailout, and the test plan. Which I think
is addressed here in this code. as mentioned.
Sorry, I don't understand what you mean.
basically making sure all the extents are really encoded, does not
matter which crypto (unless like in compress where extents may not
be encoded,in some situation) and having a test plan, now the test
plan is same as
mount option -o 'compress=ctr(aes)' with dummykey or dummy encrypt.
for encryption.
Thanks for integrating most of the patches in the ML.
-Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
