On Wed, Jan 25, 2017 at 08:42:01AM +0800, Qu Wenruo wrote: > >> So this implies the current implementation is not good enough for review. > > > > I'd say the code hasn't been cleaned up for a long time so it's not good > > enough for adding new features and doing broader fixes. The v2 rework > > has fixed quite an important issue, but for other issues I'd rather get > > smaller patches that eg. prepare the code for the final change. > > Something that I can review without needing to reread the whole convert > > and refresh memories about all details. > > > >> I'll try to extract more more set operation and make the core part more > >> refined, with more ascii art comment for it. > > > > The ascii diagrams help, the overall convert design could be also better > > documented etc. At the moment I'd rather spend some time on cleaning up > > the sources but also don't want to block the fixes you've been sending. > > I need to think about that more. > > Feel free to block the rework. > > I'll start from sending out basic documentations explaining the logic > behind convert/rollback, which should help review.
FYI, I've reorganized the convert files a bit, this patchset does not apply anymore, but I'm expecting some more changes to it so please adapt it to the new file structure. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
