> -----Original Message----- > From: linux-btrfs-ow...@vger.kernel.org [mailto:linux-btrfs- > ow...@vger.kernel.org] On Behalf Of Marat Khalili > Sent: Friday, 15 September 2017 7:50 PM > To: Hugo Mills <h...@carfax.org.uk>; Goffredo Baroncelli > <kreij...@inwind.it>; linux-btrfs <linux-btrfs@vger.kernel.org> > Subject: Re: BUG: BTRFS and O_DIRECT could lead to wrong checksum and > wrong data > > May I state my user's point of view: > > I know one applications that uses O_DIRECT, and it is subtly broken on BTRFS. > I know no applications that use O_DIRECT and are not broken. > (Really more statistics would help here, probably some exist that provably > work.) According to developers making O_DIRECT work on BTRFS is difficult if > not impossible. Isn't it time to disable O_DIRECT like ZFS does AFAIU? Data > safety is certainly more important than performance gain it may or may not > give some applications.
I agree - I've had trouble with this before because I didn't understand the consequences of using it. It would be better to hide it behind a mount option or similar IMHO. Paul.
