On 09/15/2017 11:50 AM, Marat Khalili wrote: > May I state my user's point of view: > > I know one applications that uses O_DIRECT, and it is subtly broken > on BTRFS. I know no applications that use O_DIRECT and are not > broken. (Really more statistics would help here, probably some exist > that provably work.) According to developers making O_DIRECT work on > BTRFS is difficult if not impossible. Isn't it time to disable > O_DIRECT like ZFS does AFAIU? Data safety is certainly more important > than performance gain it may or may not give some applications.
I agree with you, but it should be sufficient to disable O_DIRECT when the file has the checksums. I was unable to observe filesystem corruption when the checksums are disabled. The use cases where O_DIRECT is useful are VM and databasesM and in these cases also nodatacsum/nodatacow are useful. BR G.Baroncelli > > -- > > With Best Regards, Marat Khalili > > -- To unsubscribe from this list: send the line "unsubscribe > linux-btrfs" in the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it> Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html