On Fri, Oct 13, 2017 at 09:10:52AM -0400, Josef Bacik wrote: > On Fri, Oct 13, 2017 at 11:39:15AM +0300, Nikolay Borisov wrote: > > > > > > On 29.09.2017 22:43, Josef Bacik wrote: > > > > > > +static inline void btrfs_mod_outstanding_extents(struct btrfs_inode > > > *inode, > > > + int mod) > > > +{ > > > + ASSERT(spin_is_locked(&inode->lock)); > > > + inode->outstanding_extents += mod; > > > + if (btrfs_is_free_space_inode(inode)) > > > + return; > > > +} > > > + > > > +static inline void btrfs_mod_reserved_extents(struct btrfs_inode *inode, > > > + int mod) > > > +{ > > > + ASSERT(spin_is_locked(&inode->lock)); > > > > lockdep_assert_held(&inode->lock); for both functions. I've spoken with > > Peterz and he said any other way of checking whether a lock is held, I > > quote, "must die" > > > > Blah I continually forget that's what we're supposed to use now.
I try to keep such information on https://btrfs.wiki.kernel.org/index.php/Development_notes#BCP Just started the section with best practices, feel free to add more. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html