On 2017年12月19日 19:24, Nikolay Borisov wrote: > > > On 19.12.2017 13:20, Qu Wenruo wrote: >> Naming like pad1/2 will make the check in btrfs_qgroup_inherit() look >> quite weird. >> >> Although I don't have any better idea, so I'm mostly fine with such rename. > > Right, I saw the check now, missed it the first time. I think we should > remove it and the code should completely ignore these values. Ideally, > we would have removed them from qgroup_inherit struct as well but this > means breaking the on-disk format. So let's ignore them altogether.
Ignoring the values completely seems quite reasonable. I'll update the patch. Thanks, Qu > >> >> Thanks,
signature.asc
Description: OpenPGP digital signature
