On Fri, May 18, 2018 at 05:14:35PM +0200, David Sterba wrote: > On Fri, May 11, 2018 at 01:13:28PM -0700, Omar Sandoval wrote: > > This is the fourth (and hopefully final) version of the orphan item > > early ENOSPC and related fixes. > > > > Changes since v3: > > > > - Changed another stale comment in patch 1 > > - Moved BTRFS_INODE_ORPHAN_META_RESERVED flag removal to patch 10 > > instead of patch 9 > > - Moved inode runtime flag renumbering to a separate patch (patch 11) > > - Added some more reviewed-bys > > Patchset added to misc-next, thanks. Besides fstests, I've hammered it > with some stress testing, all fine.
Thanks, Dave! > > Changes since v2: > > > > - Add patch 5 to get rid of BTRFS_INODE_HAS_ORPHAN_ITEM > > - Move patch 10 to patch 6 > > - Got rid of patch 5; the bug goes away in the process of removing code > > for patches 9 and 10 > > - Rename patch 10 batch to what it was called in v1 > > > > Changes since v1: > > > > - Added two extra cleanups, patches 10 and 11 > > - Added a forgotten clear of the orphan bit in patch 8 > > - Reworded titles of patches 6 and 9 > > - Added people's reviewed-bys > > > > Cover letter from v1: > > > > At Facebook we hit an early ENOSPC issue which we tracked down to the > > reservations for orphan items of deleted-but-still-open files. The > > primary function of this series is to fix that bug, but I ended up > > uncovering a pile of other issues in the process, most notably that the > > orphan items we create for truncate are useless. > > > > I've also posted an xfstest that reproduces this bug. > > > > Thanks! > > > > *** BLURB HERE *** > > Blurb! Oops ;) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html