On Mon, Jun 04, 2018 at 11:00:28PM +0800, Anand Jain wrote: > Add bitmap btrfs_fs_devices::volume_state to maintain the volume states and > flags. This patch in perticular converts btrfs_fs_devices::rotating into > flag BTRFS_VOLUME_STATE_ROTATING.
I'm not sure we need this. There are 2 flags, we don't need the atomicity of test/set _bit, the values don't change too often so protecting by the mutex should be suffictient. The size of btrfs_device is also not a big concern, it will be stored in the 512 byte kmalloc bin and it's size is close to the size so replacing 2 ints with one long will not gain anything. The 3rd flag would cause other problems and is not the right solution to the scan/mount problem. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
