we already expect log tree root generation always to be super block genration + 1.
This is close to what I was looking for by reading the cover-letter, basically what is the impact/bug by not populating it? but can you explain more, I wonder how was check working so long then?
But it could be later used to detect log tree corruption early.
If there is no impact/bug its rather a good idea to change this when the early log tree corruption detection part is ready. So that there is absolute clarity. The reason why I am grossly wary is - we have incomplete business about how do we handle the write-hole, say raid1 to begin with. Thanks, Anand