On Mon, Nov 26, 2018 at 11:14:12AM +0200, Nikolay Borisov wrote: > > - if (global_rsv->space_info->full) { > > - num_dirty_bgs_bytes <<= 1; > > - num_bytes <<= 1; > > - } > > + struct btrfs_block_rsv *global_rsv = &fs_info->global_block_rsv; > > + struct btrfs_block_rsv *delayed_refs_rsv = &fs_info->delayed_refs_rsv; > > + u64 reserved; > > + bool ret = false; > > nit: Reverse christmas tree:
Let it be known that the reverse-xmas-tree declaration style will _not_ be enforced in new patches and cleanup patches only reordering declarations will not be accepted. You're free to use it but I may edit your patch so the declaration conforms to the style used in the file or to a pattern that's common the subsystem, eg. global pointers like fs_info or root first in the list.