On Fri, Mar 01, 2019 at 10:47:59AM +0800, Qu Wenruo wrote: > +enum { > + IO_TREE_FS_INFO_FREED_EXTENTS0, > + IO_TREE_FS_INFO_FREED_EXTENTS1, > + IO_TREE_INODE_IO_TREE, > + IO_TREE_INODE_IO_FAILURE_TREE, > + IO_TREE_RELOC_BLOCKS, > + IO_TREE_TRANSACTION_DIRTY_PAGES, > + IO_TREE_ROOT_DIRTY_LOG_PAGES, > + IO_TREE_SELFTEST_TMP,
Well, I guess that's always something that sounds like a pointless nitpicking but future code readers will complain, so allow me to complain now. IO_TREE_INODE_IO_TREE repeats the 'IO_TREE', so my idea is do only IO_TREE_INODE_IO, similarly IO_TREE_INODE_IO_FAILURE. And IO_TREE_SELFTEST, the 'TMP' part seems redundant.