On Fri, Mar 01, 2019 at 10:48:00AM +0800, Qu Wenruo wrote:
> +#define show_extent_io_tree_owner(owner)                                   \
> +     __print_symbolic(owner,                                               \
> +             { IO_TREE_FS_INFO_FREED_EXTENTS0,       "FREED_EXTENTS0" },   \
> +             { IO_TREE_FS_INFO_FREED_EXTENTS1,       "FREED_EXTENTS1" },   \
> +             { IO_TREE_INODE_IO_TREE,                "IO_TREE" },          \
> +             { IO_TREE_INODE_IO_FAILURE_TREE,        "IO_FAILURE_TREE" },  \
> +             { IO_TREE_RELOC_BLOCKS,                 "RELOCATION" },       \
> +             { IO_TREE_TRANSACTION_DIRTY_PAGES,      "TRANS_DIRTY_PAGES" },\
> +             { IO_TREE_ROOT_DIRTY_LOG_PAGES,         "ROOT_DIRTY_LOG" },   \
> +             { IO_TREE_SELFTEST_TMP,                 "SELFTEST_TMP" })

Additional to the previous patch, I think the point of the strings is to
match the constants or at least be an exact substring. When I see a
trace event I can simply copy&paste and search inside the sources if I'm
interested. So in this case it would be without the IO_TREE_ prefix.

I'm going to update the patche as it's only a simple rename, no need to
resend.

Reply via email to